SOLR-18081: ShardRequestTracker should use a unique key for requests #4068
+184
−66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18081
Instead of indexing results by just the node name, the results should be indexed by node and replica, which is a unique key.
Also, when async is used, the failures and successes should be added just once to the result list. So a success in creating an Async request will not add a
successresponse, it will wait for the actual async status to add that. But a failure in creating an Async request will add afailureresponse, because there will be no async status to add later. Currently a failed async request will add asuccessfor the creation of the async request, and afailureor the status of the async request, which is very confusing.