Fix NPE on class init if solr tests base is not provided (and doesn't exist).#4225
Open
dweiss wants to merge 1 commit intoapache:mainfrom
Open
Fix NPE on class init if solr tests base is not provided (and doesn't exist).#4225dweiss wants to merge 1 commit intoapache:mainfrom
dweiss wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR intends to prevent a null-pointer failure during ExternalPaths initialization when the Solr source/test base directory can’t be determined (e.g., when tests.src.home isn’t provided and the expected directories don’t exist).
Changes:
- Fixes the short-circuit evaluation order in the directory-walk loop so
baseis checked for null before callingbase.resolve(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Path base = file.toAbsolutePath(); | ||
| while (!Files.exists(base.resolve("solr/test-framework/build.gradle")) && null != base) { | ||
| while (null != base && !Files.exists(base.resolve("solr/test-framework/build.gradle"))) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of arguments in the loop is not right.