SOLR-18163: Remove v2-disabling sysprop#4233
Draft
gerlowskija wants to merge 3 commits intoapache:mainfrom
Draft
SOLR-18163: Remove v2-disabling sysprop#4233gerlowskija wants to merge 3 commits intoapache:mainfrom
gerlowskija wants to merge 3 commits intoapache:mainfrom
Conversation
Solr has long supported an experimental sysprop `solr.api.v2.enabled` that can be used to disable the v2 API if set to false. This has been a nice safety-valve for users, but it prevents us from doing any dog-fooding of the v2 APIs since it makes it possible for the APIs to not be available at all. The v2 APIs are maturing and would really benefit from this additional testing and feedback. For this reason, this commit removes the experimental system property and all references to v2 "optionality" in the codebase.
github-actions
bot
added
documentation
Contributor
Author
|
Still TODO here:
This PR is for 'main' only. But when we backport this to branch_10x, we should also put a check on startup that can log a message if the (now defunct) system property is specified, so that users can notice that this former config option is no longer actually doing anything for them. |
dsmiley
approved these changes
Mar 21, 2026
epugh
approved these changes
Mar 21, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
One idea... Do we need a way of flagging no longer used system properties/settings in a global way? Similar to the DeprecatedSystemPropertyMappings.properties that would loudly warn, but not break things?
I could see this being added to such a file...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18163
Description
Solr has long supported an experimental sysprop
solr.api.v2.enabledthat can be used to disable the v2 API if set to false. This has been a nice safety-valve for users, but it prevents us from doing any dog-fooding of the v2 APIs since it makes it possible for the APIs to not be available at all.The v2 APIs are maturing and would really benefit from this additional testing and feedback.
Solution
This commit removes the experimental system property and all references to v2 "optionality" in the codebase.
Tests
Modifications to a BATS test meant to test our deprecation sysprop warnings.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.