SOLR-18188: httpClient is left open causing flaky nightly o.a.s.cloud.ChaosMonkeyNothingIsSafeTest - #4709
Open
epugh wants to merge 1 commit into
Open
SOLR-18188: httpClient is left open causing flaky nightly o.a.s.cloud.ChaosMonkeyNothingIsSafeTest#4709epugh wants to merge 1 commit into
epugh wants to merge 1 commit into
Conversation
…NothingIsSafeTest test
epugh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18188
Description
I noticed that the nightly main builds on jenkins have been failing for a bit: https://ci-builds.apache.org/job/Solr/job/Solr-NightlyTests-main/1878/
I looked and saw two tests. I asked Claude to dig in, and it came back the work in SOLR-18188 as the probably cause. Did some testing, and here is what makes a reproducible failure on main, and a fix on this branch:
./gradlew :solr:core:test --tests "org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest"
-Ptests.nightly=true -Ptests.seed=DEAD00000000004 --rerun-tasks
-Ptests.seed=DEAD00000000004andDEAD00000000005are seeds that drawrunFullThrottle=trueand reliably reproduce theHttpJettySolrClientleak without the fix. With the fix applied, both pass. Seeds that drawrunFullThrottle=false(e.g.DEAD00000000001) pass either way, so use one of the two seeds above to exercise the affected path.Solution
Claude and I looked and he recommended this
IOUtils.closeQuietly.Tests
Ran the failing test on branch, it passes, on main, it fails.