[SPARK-54696][CONNECT] Clean-up ArrowBuffers in Connect #53452
+83
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
commented
Dec 12, 2025
|
|
||
| } else { | ||
| if (batchStructType != structType) { | ||
| throw InvalidInputErrors.chunkedCachedLocalRelationChunksWithDifferentSchema() |
Contributor
Author
There was a problem hiding this comment.
An error like this is thrown in the iterator. We may want to make this nicer though...
hvanhovell
commented
Dec 12, 2025
| } | ||
| combinedRows = combinedRows ++ batchRows | ||
| } | ||
| val (rows, structType) = ArrowConverters.fromIPCStream( |
Contributor
Author
There was a problem hiding this comment.
We can move this code into buildLocalRelationFromRows now...
hvanhovell
commented
Dec 12, 2025
| val messages = ipcStreams.map { bytes => | ||
| new MessageIterator(new ByteArrayInputStream(bytes), allocator) | ||
| } | ||
| new ConcatenatingArrowStreamReader(allocator, messages, destructive = true) |
Contributor
Author
There was a problem hiding this comment.
This is reusing a component that was used in the Spark Connect Scala client. It allows us to concatenate multiple IPC streams.
hvanhovell
commented
Dec 12, 2025
| resources.append(reader) | ||
|
|
||
| private val root: VectorSchemaRoot = try { | ||
| reader.getVectorSchemaRoot |
Contributor
Author
There was a problem hiding this comment.
The read owns the vector schema root. We don't have to manage that.
hvanhovell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a memory leak in Spark Connect LocalRelations.
... more details TBD ...
Why are the changes needed?
It fixes a stability issue.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.
A Connect Planner Test TBD
Longevity tests.
Was this patch authored or co-authored using generative AI tooling?
No.