[SPARK-54694][K8S] Fail app on ConfigMap size over limit #53455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Validate the size of each ConfigMap during its creation and fail app on its size over limit.
Why are the changes needed?
Currently, when the combined size of configuration files exceeds the Kubernetes ConfigMap size limit, Spark silently skips loading some files. This behavior is problematic because it can lead to unexpected missing configurations, potentially causing application failures or incorrect runtime behavior.
Furthermore, the current validation logic is incomplete and inconsistent:
Does this PR introduce any user-facing change?
Yes. Application will fail when ConfigMap size is over limit instead of skipping conf files.
How was this patch tested?
UT.
Was this patch authored or co-authored using generative AI tooling?
No.