Skip to content

[SPARK-54762][PYTHON] Fix _create_converter and covert overload signature #53467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaogaotiantian wants to merge 2 commits into from
+4 −2
Closed

[SPARK-54762][PYTHON] Fix _create_converter and covert overload signature #53467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1febd4
Fix _create_converter overload signature
gaogaotiantian Dec 13, 2025
61e3669
Fix convert too
gaogaotiantian Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/pyspark/sql/conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def _create_converter(
dataType: DataType,
nullable: bool = True,
*,
none_on_identity: bool = True,
none_on_identity: bool = False,
Copy link
Contributor

@zhengruifeng zhengruifeng Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ueshin on this change.

int_to_decimal_coercion_enabled: bool = False,
) -> Optional[Callable]:
pass
Expand Down Expand Up @@ -811,7 +811,9 @@ def convert(table: "pa.Table", schema: StructType, *, binary_as_bytes: bool) ->

@overload
@staticmethod
def convert(table: "pa.Table", schema: StructType, *, return_as_tuples: bool) -> List[tuple]:
def convert(
table: "pa.Table", schema: StructType, *, return_as_tuples: bool
) -> List[Row | tuple]:
pass

@staticmethod # type: ignore[misc]
Expand Down