[SPARK-55986][PYTHON] Upgrade black to 26.3.1#54782
[SPARK-55986][PYTHON] Upgrade black to 26.3.1#54782LuciferYang wants to merge 9 commits intoapache:masterfrom
Conversation
|
test first |
|
cc @HyukjinKwon Although the intention is to fix https://github.com/apache/spark/security/dependabot/172, this would result in a large number of files being re-formatted. Please help make a decision on whether to proceed with the upgrade. Thanks ~ |
|
All test paased |
|
Merged to master. Thank you, @LuciferYang . |
|
Thank you @dongjoon-hyun |
|
I think we should (soon) move to |
ruff is indeed extremely fast, roughly 100 times faster than black (on a PySpark project, Ruff took 0.12 seconds while Black took 12.9 seconds). Moreover, it requires minimal modifications to the toolchain. The downside is that this action will result in a massive number of code changes: 761 files, with +31K/-10K lines. We need to carry out this task during a low-traffic period and add this commit record to the .git-blame-ignore-revs file. cc @dongjoon-hyun @HyukjinKwon @zhengruifeng WDYT? |
|
@LuciferYang you probably ran I think we should do it sooner than later because for people who did not work on spark super recently, they will only experience one big code refactoring (black + ruff). If we postpone it, more people will experience twice. |
|
@gaogaotiantian and @LuciferYang . We had better discuss on #54840 instead of here. Otherwise, most of people are not aware of it. 😄 The Apache Spark community is already one of the biggest community. Given that, please send an email with the title |
Sure! Will do. |
What changes were proposed in this pull request?
This pr aims to upgrade black from 23.12.1 to 26.3.1
Why are the changes needed?
To fix https://github.com/apache/spark/security/dependabot/172
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions
Was this patch authored or co-authored using generative AI tooling?
No