THRIFT-5242: Add Homebrew installation instructions for macOS

[slachiewicz]

JIRA: THRIFT-5242
Client: doc

Description

Update doc/install/os_x.md to:

• Document installing the pre-built Thrift compiler via Homebrew (brew install thrift).
• Document building from source using Homebrew-provided dependencies with both CMake and Autotools.
• Add guidance regarding macOS's outdated default bison (v2.3) and the keg-only Homebrew bison.
• Modernize external links to HTTPS (https://www.boost.org, https://libevent.org, https://thrift.apache.org/download).

This change was created with AI assistance.

[Jens-G]

Code review

Found 2 issues:

1. The Autotools recipe does not work with the dependencies the page lists. brew install cmake boost libevent openssl bison flex installs none of autoconf, automake, libtool or pkg-config, and macOS does not ship them. The recipe starts with ./bootstrap.sh, which exits with "Couldn't find libtoolize!" when libtool is missing. It also requires automake 1.13 or later and runs aclocal/autoconf/automake, and configure.ac needs the pkg-config macros. The macOS CI job installs automake bison flex boost libevent openssl libtool pkg-config before running the same steps. (bug due to doc/install/os_x.md: brew install cmake boost libevent openssl bison flex, followed by ./bootstrap.sh)

thrift/doc/install/os_x.md

Lines 23 to 25 in 362d954

	```bash
	brew install cmake boost libevent openssl bison flex
	```

thrift/.github/workflows/build.yml

Lines 131 to 133 in 362d954

	run: |
	brew install automake bison flex boost libevent openssl libtool pkg-config
	echo "$(brew --prefix bison)/bin" >> $GITHUB_PATH

2. The commit has no AI attribution trailer, although the PR description says the change was created with AI assistance (AGENTS.md says "Always label AI-assisted commits and PRs. Use one or both of: Co-Authored-By: <AI tool name and version> / Generated-by: <AI tool name and version>").

thrift/AGENTS.md

Lines 60 to 74 in 362d954

	- **Always** label AI-assisted commits and PRs. Use one or both of:
	```
	Co-Authored-By: <AI tool name and version>
	Generated-by: <AI tool name and version>
	```
	Example:
	```
	THRIFT-9999: Fix connection timeout handling in Go client
	Client: go
	Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
	```
	- Apply this label even when AI only generated a portion of the change.
	- **Never** put tool-internal links into a commit message, PR description, JIRA comment or e-mail.

Two suggestions, below the bar for the list above but verified:

• The page is about installing the compiler, but the CMake recipe runs with the default options. Those also build the libraries, tests and tutorials (BUILD_LIBRARIES, BUILD_TESTING and BUILD_TUTORIALS default to ON), and the tests need compiled Boost libraries. The compiler-only options used in doc/ReleaseManagement.md (-DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF -DWITH_CPP=OFF … -DBUILD_COMPILER=ON) would match what the page promises. Also, the macOS CI job only runs the Autotools path, so the recipe marked "(Recommended)" is the one that is not tested.

thrift/doc/install/os_x.md

Lines 28 to 37 in 362d954

	#### Building with CMake (Recommended)
	```bash
	cmake -B build \
	-DBISON_EXECUTABLE="$(brew --prefix bison)/bin/bison" \
	-DOPENSSL_ROOT_DIR="$(brew --prefix openssl)"
	cmake --build build
	sudo cmake --install build
	```

• export LDFLAGS="-L$(brew --prefix bison)/lib" is not needed. bison only runs as a program and nothing links against it; CI only adds bison's bin directory to PATH. The export also replaces any LDFLAGS the reader already has set.

thrift/doc/install/os_x.md

Lines 41 to 44 in 362d954

	```bash
	export PATH="$(brew --prefix bison)/bin:$PATH"
	export LDFLAGS="-L$(brew --prefix bison)/lib"

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[slachiewicz]

Rewrote the branch after the review above:

• The Homebrew line now installs automake libtool pkg-config as the macOS CI job does, so ./bootstrap.sh finds libtoolize.
• Both recipes build only the compiler, which is what the page promises: --disable-libs --disable-tests for Autotools and -DBUILD_LIBRARIES=OFF -DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF for CMake. Neither needs Boost, libevent or OpenSSL, so those moved to a sentence for readers who also want the C++ library.
• Dropped the LDFLAGS export and the "(Recommended)" label.
• The CMake recipe now builds into cmake-build. cmake -B build reuses the repository's own build/ directory, which holds the CMake modules.
• The commit carries the attribution trailer.

Verified: both recipes run as written on macOS 15 (Apple Silicon) → thrift -version prints 0.25.0 from each build.

This comment was created with AI assistance.

[slachiewicz]

A limit on the verification above, since I had no clean macOS environment for it:

• The sudo … install steps ran into a scratch prefix (cmake --install --prefix, make install DESTDIR=), so the install target is tested but not the /usr/local permissions.
• flex on the test machine came from Xcode, not Homebrew, so the brew install line was not exercised from a fresh machine. All six formula names resolve.
• The unchanged section on building Boost and libevent by hand was not run.

The macOS CI job covers the Autotools path on a fresh runner; the CMake path has no CI coverage.

This comment was created with AI assistance.