Test DNS TCP split length reads - #13561
Closed
bneradt wants to merge 1 commit into
Closed
Conversation
Add a unit test for accumulating the DNS-over-TCP length prefix one byte at a time. Move the prefix state update into DNSConnection::TCPData so the split-read behavior can be exercised without constructing a DNSHandler.
Contributor
|
Do you know whether it's possible to test this through a public interface? |
Contributor
Author
I don't think easily. This came out of another code review. I don't like the tail wagging the dog (cluttering the API for the test). I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a unit test for accumulating the DNS-over-TCP length prefix one byte at a time. Move the prefix state update into DNSConnection::TCPData so the split-read behavior can be exercised without constructing a DNSHandler.