Compact response HTTP version log fields - #13568
Merged
Merged
Conversation
The sshv and csshv access log fields store two one-byte version components as separate 64-bit integers, consuming 16 bytes per entry and publishing dINT framing in binary log schemas. This patch addresses the overhead by marshaling major.minor strings in one 8-byte-aligned slot while preserving the existing HTTP/major.minor ASCII form. It updates v3 schema expectations and regression coverage for both fields. Fixes: apache#12891
maskit
approved these changes
Aug 19, 2026
maskit
left a comment
maskit
left a comment
Member
There was a problem hiding this comment.
I wonder if we should keep dINT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sshv and csshv access log fields store two one-byte version
components as separate 64-bit integers, consuming 16 bytes per entry and
publishing dINT framing in binary log schemas.
This patch addresses the overhead by marshaling major.minor strings in
one 8-byte-aligned slot while preserving the existing HTTP/major.minor
ASCII form. It updates v3 schema expectations and regression coverage
for both fields.
Fixes: #12891