Open
Conversation
d6aa3e1 to
8c93df1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #706 +/- ##
========================================
Coverage 61.80% 61.80%
========================================
Files 709 709
Lines 40375 40382 +7
Branches 5686 5692 +6
========================================
+ Hits 24954 24959 +5
Misses 14723 14723
- Partials 698 700 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c93df1 to
46de126
Compare
9d28d1f to
9e1edf5
Compare
jt2594838
approved these changes
Feb 5, 2026
9e1edf5 to
1b3c275
Compare
jt2594838
reviewed
Feb 9, 2026
jt2594838
approved these changes
Feb 13, 2026
Comment on lines
+79
to
+86
| FORCE_INLINE int get_time_column_index() const { | ||
| for (uint32_t i = 0; i < column_list_.size(); i++) { | ||
| if (column_list_[i].get_column_category() == ColumnCategory::TIME) { | ||
| return i; | ||
| } | ||
| } | ||
| return -1; | ||
| } |
Contributor
There was a problem hiding this comment.
Save the index to avoid iteration every time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.