Skip to content

Conversation

@guan404ming
Copy link
Member

Why

Resolve todo in tests/python/relax/test_ast_printer.py

How

  • Added a new test function test_op_attrs in tests/python/relax/test_ast_printer.py.
  • Removed the TODO comment.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test case to the Relax AST printer to ensure that operation attributes are correctly represented when an AST node is converted to a string. This improves the robustness of the AST printer by validating its behavior with more complex node structures, specifically those involving custom attributes on operations.

Highlights

  • New Test Case: A new test case, test_op_attrs, has been added to verify the AST printer's ability to correctly handle and print Op attributes.
  • AST Printer Coverage: This change specifically enhances the test coverage for the AST printer in the Relax framework, ensuring proper serialization of operation attributes.
  • TODO Resolution: A previously existing TODO comment in tests/python/relax/test_ast_printer.py, which requested the addition of a test case for op attrs, has been resolved and removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds a test case for operator attributes in the AST printer, resolving a TODO. The implementation is correct and the test is valuable. I've provided one suggestion to refactor the attribute creation to use a more direct and idiomatic approach, which will make the code simpler and more readable.

guan404ming and others added 2 commits December 27, 2025 13:05
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@guan404ming guan404ming marked this pull request as ready for review December 27, 2025 20:34
@guan404ming
Copy link
Member Author

cc @tlopex @mshr-h

@mshr-h mshr-h merged commit 41cac2e into apache:main Dec 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants