[Relax][Frontend][TFLite] Add bucketize/unique/sign + fixes#19522
Open
0xjah wants to merge 4 commits into
Open
[Relax][Frontend][TFLite] Add bucketize/unique/sign + fixes#195220xjah wants to merge 4 commits into
0xjah wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for several TFLite operators—BUCKETIZE, RELU_0_TO_1, SIGN, and UNIQUE—to the Relax frontend and enables dynamic scalar inputs for the RANGE operator. It also hardens FAKE_QUANT against division-by-zero errors in degenerate ranges. Review feedback identifies a semantic mismatch in the BUCKETIZE implementation regarding boundary matching, suggests using math.floor(x + 0.5) for TFLite-compliant rounding in quantized RELU_0_TO_1, and recommends adding a specific test case for the FAKE_QUANT degenerate range fix.
Member
|
Could you have a look at CI and fix the error? |
…ake quantization case
Rebase branch onto upstream/main (apache/tvm), resolving conflicts from newly merged LSTM, RNN, CALL/CALL_ONCE, and resource-variable ops. Restore uncommitted float32 guard in qnn_params to prevent fake-quant tensors from being treated as quantized.
0xjah
force-pushed
the
relax-tflite-missing-ops
branch
from
1373348 to
481ebd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing