#634#647
Closed
novatechflow wants to merge 5 commits intoapache:mainfrom
Closed
Conversation
…rdered sets for scope/slot tracking, add stable cost tiebreaker, and cover with determinism tests.
Member
Author
|
Since #634 popped up in the main PR I thought bring them together would make sense. |
juripetersen
reviewed
Jan 8, 2026
Contributor
There was a problem hiding this comment.
This file should probably not be in this PR right?
I think a PR should only ever contain changes relevant for the issue it is trying to solve.
What do you think?
juripetersen
reviewed
Jan 8, 2026
juripetersen
reviewed
Jan 8, 2026
| writeTextFileJava(url, toSerializableFunction(formatterUdf), udfLoad) | ||
| } | ||
|
|
||
| def writeParquet(url: String, overwrite: Boolean = false)(implicit ev: Out =:= Record): Unit = |
juripetersen
reviewed
Jan 8, 2026
| * @param projection the projection, if any | ||
| * @return [[DataQuantaBuilder]] for the file | ||
| */ | ||
| def readParquetAsDataset(url: String, projection: Array[String] = null): UnarySourceDataQuantaBuilder[UnarySourceDataQuantaBuilder[_, Record], Record] = |
juripetersen
reviewed
Jan 8, 2026
| * @param projection the projection, if any | ||
| * @return [[DataQuanta]] of [[Record]]s backed by a Spark Dataset when executed on Spark | ||
| */ | ||
| def readParquetAsDataset(url: String, projection: Array[String] = null): DataQuanta[Record] = |
juripetersen
reviewed
Jan 8, 2026
juripetersen
requested changes
Jan 8, 2026
Contributor
juripetersen
left a comment
juripetersen
left a comment
There was a problem hiding this comment.
Please remove the files not concerning the issue #634
Member
Author
|
Closing in favor of #662, which cleanly separates determinism fixes/tests from the Spark DataFrames work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix the non-deterministic enumeration. Main issue from my point of view was that we relied completely on plain
HashSetall over the place => the order changed every time the JVM ran, therefore a unpredictable hash-set ordering was the root cause.Wrote a regression test, too:
mvn -pl wayang-commons/wayang-core -Dtest=PlanEnumerationDeterminismTest,ChannelConversionGraphDeterminismTest test