Conversation
vdusek
added
adhoc
vdusek
added
adhoc
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 85.85% 85.78% -0.08%
==========================================
Files 46 46
Lines 2765 2778 +13
==========================================
+ Hits 2374 2383 +9
- Misses 391 395 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
is_finished checks in shared RQ integration testsis_finished checks in shared RQ integration tests
In shared request queue mode, there is an API propagation delay before handled requests are reflected. Tests checking `is_finished()` immediately after processing could return `False` due to stale API state. Introduce a generic `call_with_exp_backoff` helper in `tests/integration/_utils.py` that retries any async callable with exponential backoff until it returns a truthy value. This replaces the previous `fetch_next_request_with_exp_backoff` and is now also used for `is_finished()` checks in shared mode across all affected tests: - test_add_and_fetch_requests - test_add_requests_in_batches - test_add_non_unique_requests_in_batch - test_request_reclaim_functionality - test_batch_operations_performance - test_state_consistency - test_large_batch_operations - test_rq_long_url - test_request_queue_is_finished Failed run: https://github.com/apify/apify-sdk-python/actions/runs/22375456542/job/64764491226?pr=812 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
force-pushed
the
test/fix-flaky-batch-operations-performance-shared
branch
from
de4046d to
3f7145e
Compare
Pijukatel
reviewed
Feb 25, 2026
Pijukatel
approved these changes
Feb 26, 2026
vdusek
deleted the
test/fix-flaky-batch-operations-performance-shared
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_with_exp_backoffhelper intests/integration/_utils.pythat retries any async callable with exponential backoff until it returns a truthy value, replacing the previousfetch_next_request_with_exp_backoffis_finished()checks in shared request queue mode across 9 integration tests to handle API propagation delaysrequest: pytest.FixtureRequestto fix type checker errorsTest plan
singleandsharedRQ modes)is_finishedfailures in shared modeMotivation
One of the failed run: https://github.com/apify/apify-sdk-python/actions/runs/22375456542/job/64764491226?pr=812
🤖 Generated with Claude Code