-
Notifications
You must be signed in to change notification settings - Fork 461
Add support for custom accessibility actions #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for custom accessibility actions #1095
Conversation
|
|
The PR looks ok Please also add some integration tests to cover the new functionality for page source generation and element attributes fetching. Also, do not forget to update the element double declaration in unit tests |
Add support for exposing custom accessibility actions from UI elements
400c791 to
6fbf62e
Compare
| NSLog(@"[FBCustomActions] Custom action title: %@", title); | ||
| } | ||
|
|
||
| NSString *joined = [stringified componentsJoinedByString:@", "]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a space after ,? If not, then it makese sense to use only , to not add redundant spaces in WDA layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KazuCocoa Thank you for pointing it out. I wonder if comma delimiter is reliable at all since action titles can contain commas themselves so consumers can’t reliably split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant a space after , like below was needed here:
ah, you meant conman itself also. Agree with that, but I have no much good idea another word though
Add element double declaration for custom actions in unit tests.
Add element attributes fetching integration test.
Summary
This PR introduces support for exposing accessibility custom actions as an element attribute using private XCTest APIs.
Motivation
Once this is in place:
Implementation Notes
_XC_kAXXCAttributeCustomActionsThese changes are additive, so they do not change existing behaviour.