Repository navigation
fix: preserve shared rootfs during serial test cleanup - #993
Open
StefanPrintezis wants to merge 1 commit into
Open
StefanPrintezis wants to merge 1 commit into
StefanPrintezis wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing integration tests for my other PR I noticed i could not run the integration tests serially:
Summary
There seems to be an issue when bootstrapping/cleaning up the shared rootfs. Cleanup compares the shared rootfs path with directory entries, but macOS can return
/var/...and/private/var/...for the other. These point to the same file. The comparison treats it as an old test file, deletes it, and the next copy operation fails.This cleanup only runs with one worker (--max-concurrency 1). The default four-worker run skips it because other tests may still need those files, so the default integration command does not expose the bug.
Fix
Compare filenames instead, since every entry comes from the same temporary directory.