Skip to content

build: add env-lowest-torch make target - #50

Merged
guru-desh merged 2 commits into
apple:mainfrom
guru-desh:create-env-lowest-torch-venv
Jul 21, 2026
Merged

build: add env-lowest-torch make target#50
guru-desh merged 2 commits into
apple:mainfrom
guru-desh:create-env-lowest-torch-venv

Conversation

@guru-desh

Copy link
Copy Markdown
Contributor

Mirrors env-highest-torch to give local dev a way to create a venv pinned to the lowest supported PyTorch version, matching what test-lowest-pytorch already builds on demand.

@guru-desh
guru-desh requested a review from dengqiaoyu July 21, 2026 00:56
@guru-desh guru-desh added the enhancement New feature or request label Jul 21, 2026
@guru-desh
guru-desh marked this pull request as ready for review July 21, 2026 00:56
Mirrors env-highest-torch to give local dev a way to create a venv
pinned to the lowest supported PyTorch version, matching what
test-lowest-pytorch already builds on demand.
…est/highest-torch

test-lowest-pytorch and test-highest-pytorch each duplicated the
TORCH_GROUP + use_env logic that env-lowest-torch/env-highest-torch
already encapsulate. Make the env-* targets a prerequisite instead, so
one place owns how each pinned-torch venv gets built.
@guru-desh
guru-desh force-pushed the create-env-lowest-torch-venv branch from 336aaac to e917ab8 Compare July 21, 2026 01:14
@guru-desh
guru-desh merged commit 3f5b05d into apple:main Jul 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants