fix(backups): accept pending lifecycle response values - #9
Open
HarshMN2345 wants to merge 2 commits into
Open
Conversation
|
Member
Author
|
@greptile-apps review Please re-review the current commit with the serialization evidence in the policy-ID discussion. Cloud's required/default response rule turns stored null policy IDs into empty strings; the corrected Cloud commit preserves that existing HTTP contract. The current SDK models are byte-identical to regeneration from that schema, and the old/new Cloud+SDK drill confirms released clients still accept completed ad-hoc archives. The four actual Sentry size/start/options regressions are still fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending backup responses and restoration options currently fail model validation after successful API requests. Regenerate the two backup models from the corrected Cloud OpenAPI declarations in cloud#5760: pending size/start times are nullable and restoration options are an object. Keep
policyIdas the established string response, including""for ad-hoc backups. Cloud's required/default response rule already converts stored null policy IDs to that empty string before serialization.Extend the existing
BackupsServiceTestcases for pending archive/restoration creation, completed ad-hoc archive retrieval, and populated restoration get/list responses. No new test class or runtime adapter is added.Addresses MCP-Y, MCP-1K, MCP-1M, and MCP-1R.
Validation:
Response::output()JSON passes through this SDK and the public MCP handler using a disposable local HTTP server, preserving null lifecycle fields, empty objects, and nested Unicode resource mappings. Completed ad-hoc archive responses also remain accepted by the released SDK.Deployment order: Cloud#5760 must deploy first so empty options arrive as
{}. Then publish this SDK under a new version and update/deploy MCP with that version in its lockfile. The currently locked SDK0.6.0 is not updated by merging these PRs alone.