Update to Selenium 4.41.0 +semver:feature#159
Merged
Conversation
Update plugins and dependencies versions. Update DevTools references. Stabilize tests
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughBumped Maven dependencies and build plugins; migrated Selenium DevTools imports from v143/v144 to v145 across main/devtools classes and tests; changed test form latitude to nullable and added test skip handling; minor Javadoc additions. No public API signature changes except the test helper returning Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pom.xml (1)
69-103:⚠️ Potential issue | 🔴 CriticalNon-existent dependency versions will cause build failures.
The specified versions do not exist on Maven Central Repository:
aquality-selenium-core 4.13.0(0 results)jackson-databind 2.21.2(0 results)testng 7.12.0(0 results)These versions must be corrected to valid versions that exist in Maven Central before the project can build. Verify the correct version numbers for each dependency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pom.xml` around lines 69 - 103, The pom declares invalid dependency versions causing build failures: update the versions for artifacts aquality-selenium-core, jackson-databind, and testng to published releases (replace aquality-selenium-core:4.13.0, jackson-databind:2.21.2, testng:7.12.0 with valid versions), confirm the chosen versions exist on Maven Central, and run mvn -U dependency:resolve to verify; edit the <dependency> entries for artifactIds aquality-selenium-core, jackson-databind, and testng to the corrected version strings.
🧹 Nitpick comments (1)
src/test/java/forms/MyLocationForm.java (1)
18-24: Document the nullable contract forgetLatitude().Line 18 now allows
null, so callers can accidentally unbox and fail later. Please make thenullbehavior explicit in method docs (or rename to reflect nullable semantics).Proposed update
+ /** + * Gets latitude from the page. + * `@return` latitude value, or null when geolocation is unavailable/blocked. + */ public Double getLatitude() {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/forms/MyLocationForm.java` around lines 18 - 24, The getLatitude() method can return null when the latitude label isn’t displayed, which risks callers unboxing a null; update its contract by adding a Javadoc comment that explicitly states the method may return null and callers must handle that case, and/or annotate the method with a nullable annotation (e.g., `@Nullable`) to make the nullable semantics explicit; alternatively, if you prefer explicit naming, rename getLatitude() to getLatitudeOrNull() and update all callers accordingly. Ensure references to getLatitude() in tests/clients are reviewed to handle null safely.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/main/java/aquality/selenium/elements/interfaces/IShadowRootExpander.java`:
- Around line 349-350: Swap the order of the two Javadoc `@param` tags so they
match the method signature in IShadowRootExpander: move the `@param` state tag to
appear before the `@param` count tag in the JavaDoc block for the method whose
signature lists state before count (referenced around line 353); ensure the
descriptions remain attached to the correct parameter names so generated API
docs are accurate.
---
Outside diff comments:
In `@pom.xml`:
- Around line 69-103: The pom declares invalid dependency versions causing build
failures: update the versions for artifacts aquality-selenium-core,
jackson-databind, and testng to published releases (replace
aquality-selenium-core:4.13.0, jackson-databind:2.21.2, testng:7.12.0 with valid
versions), confirm the chosen versions exist on Maven Central, and run mvn -U
dependency:resolve to verify; edit the <dependency> entries for artifactIds
aquality-selenium-core, jackson-databind, and testng to the corrected version
strings.
---
Nitpick comments:
In `@src/test/java/forms/MyLocationForm.java`:
- Around line 18-24: The getLatitude() method can return null when the latitude
label isn’t displayed, which risks callers unboxing a null; update its contract
by adding a Javadoc comment that explicitly states the method may return null
and callers must handle that case, and/or annotate the method with a nullable
annotation (e.g., `@Nullable`) to make the nullable semantics explicit;
alternatively, if you prefer explicit naming, rename getLatitude() to
getLatitudeOrNull() and update all callers accordingly. Ensure references to
getLatitude() in tests/clients are reviewed to handle null safely.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2151ccf1-543d-4625-aabf-e08aa1373e97
📒 Files selected for processing (12)
pom.xmlsrc/main/java/aquality/selenium/browser/devtools/DevToolsHandling.javasrc/main/java/aquality/selenium/browser/devtools/EmulationHandling.javasrc/main/java/aquality/selenium/browser/devtools/JavaScriptHandling.javasrc/main/java/aquality/selenium/browser/devtools/NetworkHandling.javasrc/main/java/aquality/selenium/elements/interfaces/IShadowRootExpander.javasrc/main/java/aquality/selenium/logging/DevToolsCommandLoggingOptions.javasrc/test/java/forms/MyLocationForm.javasrc/test/java/tests/usecases/devtools/DeviceEmulationTest.javasrc/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.javasrc/test/java/tests/usecases/devtools/OverrideGeolocationTest.javasrc/test/java/tests/usecases/devtools/OverrideUserAgentTest.java
src/main/java/aquality/selenium/elements/interfaces/IShadowRootExpander.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update plugins and dependencies versions.
Update DevTools references.
Stabilize tests