Skip to content

[Feat] added display manager entry - #77

Merged
areofyl merged 5 commits into
areofyl:mainfrom
samuelskovbakke:gather_dm
Aug 21, 2026
Merged

[Feat] added display manager entry#77
areofyl merged 5 commits into
areofyl:mainfrom
samuelskovbakke:gather_dm

Conversation

@samuelskovbakke

Copy link
Copy Markdown
Contributor

I have added a display manager entry. So users can now add displaymanager to get something like:

Display Manager: SDDM

@areofyl areofyl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works on systemd, which is a problem since fetch runs on non-systemd distros too (prime example is Gentoo). Could you detect the DM by scanning running processes (like we do for WM) instead? Also the substring search on the service file could false-positive on comments or paths: matching the ExecStart= line specifically would be more reliable. And it probably shouldn't be in the default field list since many tiling WM users don't use a DM.

@areofyl areofyl self-assigned this Aug 19, 2026
@samuelskovbakke

Copy link
Copy Markdown
Contributor Author

I have changed it to process scanning instead, but on systems that have a lot of running processes I think this is quite slow. Maybe we should rather check if the distro is running systemd and do the ExecStart= approach and only do process scanning if systemd is absent?

@areofyl areofyl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better!

@areofyl
areofyl merged commit c09a6cd into areofyl:main Aug 21, 2026
@samuelskovbakke
samuelskovbakke deleted the gather_dm branch August 21, 2026 18:23
@samuelskovbakke
samuelskovbakke restored the gather_dm branch August 23, 2026 09:42
@samuelskovbakke
samuelskovbakke deleted the gather_dm branch August 23, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants