-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: upgrade to React 18 #25332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: upgrade to React 18 #25332
Conversation
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
|
@jwinters01 can you pin the argo-ui version in this PR to the upgrade version so we get full CI here? |
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
todaywasawesome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add signoff to your commits?
Signed-off-by: Jonathan Winters <[email protected]>
|
@todaywasawesome I believe all my commits are signed off, correct me if I am wrong |
Initial changes for #25203. Upgrades core UI to React 18
NOTE: For this change to work, it also needs to be running the changes from this PR in argo-ui: argoproj/argo-ui#600. This build will fail until that PR gets merged
Checklist: