Skip to content

Conversation

@jwinters01
Copy link
Contributor

@jwinters01 jwinters01 commented Nov 18, 2025

Initial changes for #25203. Upgrades core UI to React 18

NOTE: For this change to work, it also needs to be running the changes from this PR in argo-ui: argoproj/argo-ui#600. This build will fail until that PR gets merged

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
@bunnyshell
Copy link

bunnyshell bot commented Nov 18, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
@crenshaw-dev
Copy link
Member

@jwinters01 can you pin the argo-ui version in this PR to the upgrade version so we get full CI here?

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add signoff to your commits?

Signed-off-by: Jonathan Winters <[email protected]>
@jwinters01
Copy link
Contributor Author

@todaywasawesome I believe all my commits are signed off, correct me if I am wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants