Skip to content

Conversation

@jagpreetstamber
Copy link
Contributor

@jagpreetstamber jagpreetstamber commented Dec 9, 2025

Closes #23705

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jagpreetstamber jagpreetstamber requested review from a team as code owners December 9, 2025 19:51
@bunnyshell
Copy link

bunnyshell bot commented Dec 9, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.65%. Comparing base (8fec5c5) to head (cfcc8ed).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...plicationset/services/pull_request/azure_devops.go 79.06% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25575      +/-   ##
==========================================
+ Coverage   62.60%   62.65%   +0.04%     
==========================================
  Files         353      353              
  Lines       49883    49918      +35     
==========================================
+ Hits        31229    31274      +45     
+ Misses      15660    15647      -13     
- Partials     2994     2997       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagpreetstamber jagpreetstamber force-pushed the master branch 3 times, most recently from 4412f8a to 845a1f5 Compare December 10, 2025 00:52
Copy link
Contributor

@ppapapetrou76 ppapapetrou76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach you have taken with the factory pattern and different implementations

I have left a few comments for your consideration

Copy link
Contributor

@ppapapetrou76 ppapapetrou76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅 - thanks for addressing my comments

@reggie-k reggie-k added this to the v3.4 milestone Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add support for Azure Workload Identity in Azure Devops Pull Request Generator

3 participants