-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: WorkloadIdentity support for azure devops pull request generator. #25575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
5998291 to
847ce9d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25575 +/- ##
==========================================
+ Coverage 62.60% 62.65% +0.04%
==========================================
Files 353 353
Lines 49883 49918 +35
==========================================
+ Hits 31229 31274 +45
+ Misses 15660 15647 -13
- Partials 2994 2997 +3 ☔ View full report in Codecov by Sentry. |
4412f8a to
845a1f5
Compare
ppapapetrou76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach you have taken with the factory pattern and different implementations
I have left a few comments for your consideration
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
845a1f5 to
fe523e4
Compare
…ing method. Signed-off-by: Jagpreet Singh Tamber <[email protected]>
d8a03b7 to
cfcc8ed
Compare
ppapapetrou76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏅 - thanks for addressing my comments
Closes #23705
Checklist: