Skip to content

Update log messages for trigger evaluation #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NachoxMacho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update log messages for trigger evaluation #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,10 @@ func (c *notificationController) processResourceWithAPI(api api.API, resource me
for trigger, destinations := range destinations {
res, err := api.RunTrigger(trigger, un.Object)
if err != nil {
logEntry.Errorf("Failed to execute condition of trigger %s: %v using the configuration in namespace %s", trigger, err, apiNamespace)
eventSequence.addWarning(fmt.Errorf("failed to execute condition of trigger %s: %w using the configuration in namespace %s", trigger, err, apiNamespace))
logEntry.Errorf("Failed to evaluate condition of trigger %s: %v using the configuration in namespace %s", trigger, err, apiNamespace)
eventSequence.addWarning(fmt.Errorf("failed to evaluate condition of trigger %s: %w using the configuration in namespace %s", trigger, err, apiNamespace))
}
logEntry.Infof("Trigger %s result: %v", trigger, res)
logEntry.Infof("Evaluated trigger %s condition, results: %v", trigger, res)

for _, cr := range res {
c.metricsRegistry.IncTriggerEvaluationsCounter(trigger, cr.Triggered)
Expand Down