Skip to content

Sort pre-0.4.0 versions properly#20

Open
axic wants to merge 2 commits intogh-pagesfrom
pre040
Open

Sort pre-0.4.0 versions properly#20
axic wants to merge 2 commits intogh-pagesfrom
pre040

Conversation

@axic
Copy link
Copy Markdown
Contributor

@axic axic commented Apr 2, 2018 •
edited
Loading

This fixes the sorting order for <0.4.0 -- which was changed by #8.

@axic axic marked this pull request as draft May 4, 2021 23:35
@axic axic changed the title [WIP] Sort pre-0.4.0 versions properly Sort pre-0.4.0 versions properly May 4, 2021
@axic
Copy link
Copy Markdown
Contributor Author

axic commented May 4, 2021

@cameel while this is definitely not a pressing issue, perhaps we may want to get this done?

cameel
cameel reviewed May 10, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there's any point in doing this given that there are no nightlies earlier than 0.4.10 in the repo. Or do we want to restore them?

Comment thread update Outdated
Comment thread update Outdated
@axic
Copy link
Copy Markdown
Contributor Author

axic commented Nov 10, 2021

I'm not sure there's any point in doing this given that there are no nightlies earlier than 0.4.10 in the repo.

They definitely existed, hence the PR.

Or do we want to restore them?

Hmm, I think we should have the proper history, especially as we now serve this off-github.

@cameel
Copy link
Copy Markdown
Collaborator

cameel commented Nov 10, 2021

Hmm, I think we should have the proper history, especially as we now serve this off-github.

OK then. Here's a PR that restores them: #103.

@mrx23dot

This comment has been minimized.

Sign in to view
@cameel

This comment has been minimized.

Sign in to view
@cameel cameel requested a review from r0qs November 22, 2022 15:21
@r0qs @axic @cameel
Sort pre-0.4.0 versions properly
43ac911 
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
@r0qs r0qs marked this pull request as ready for review December 8, 2022 14:28
@r0qs r0qs requested a review from cameel December 8, 2022 14:28
@cameel
Copy link
Copy Markdown
Collaborator

cameel commented Dec 12, 2022

@r0qs The PR is incomplete - the lint job is failing. Since #103 was merged, the old nightlies have been restored but lists need to be regenerated with the new sort order.

r0qs
r0qs reviewed Dec 14, 2022
View reviewed changes
Comment thread emscripten-wasm32/list.json
Comment on lines +16 to +20
"path": "solc-emscripten-wasm32-v0.3.6-workaround+commit.3fc68da5.js",
"version": "0.3.6",
"prerelease": "workaround",
"build": "commit.3fc68da5",
"longVersion": "0.3.6-workaround-workaround+commit.3fc68da5",
Copy link
Copy Markdown
Member

@r0qs r0qs Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cameel although the tests passed, I noticed one weird case here though. So please do not approve it yet. It seems that the symlink is being created with the -workaround and then the longVersion get it doubled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0qs r0qs r0qs approved these changes

@cameel cameel Awaiting requested review from cameel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@axic @cameel @mrx23dot @r0qs