Skip to content

Conversation

@EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Dec 13, 2025

Description

avoid cross-contamination from other boards/families that will use this uboot version in future

  • build test

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

avoid cross-contamination from other boards/families that will use this uboot version in future
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 13, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • Needs review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... 02 Milestone: First quarter release size/small PR with less then 50 lines labels Dec 13, 2025
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Dec 13, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Dec 13, 2025
@EvilOlaf EvilOlaf merged commit 86f473d into armbian:main Dec 13, 2025
11 checks passed
@EvilOlaf EvilOlaf deleted the r76s branch December 13, 2025 17:32
@rpardini
Copy link
Member

Thanks, I noticed this the other day as well.

Btw, since all 3 files are null-patches, they could be extracted from a .patch and be put bare in the dt_uboot/dt_upstream_rockchip/defconfig folders via the 000.patching_config.yaml magic.

@rpardini
Copy link
Member

(I expect the r76s to land upstream soon enough, so the whole thing might go away soon. I'd just rather keep v2026.01 null-patch-free if possible)

@EvilOlaf
Copy link
Member Author

Perhaps @SuperKali wants to take care of that?

@rpardini
Copy link
Member

Might wanna hold off a bit, as torvalds/linux@7fee888 just landed in 6.19-rc1 -- might take a while until u-boot rebases dts/upstream onto it

@SuperKali
Copy link
Member

@EvilOlaf I missed this PR, I just read it now, let's wait as @rpardini says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

4 participants