Surface armbian-sdk images in Dedicated Applications#19
Merged
Conversation
The SDK image (https://github.com/armbian/sdk) tags its assets with file_application=sdk via the build action's manifest writer ("6.18.26-sdk" kernel suffix). With the third-party merge step on armbian.github.io flowing those rows into armbian-images.json verbatim, the website only needs an APP_META entry to render them in the Dedicated Applications block. Adds the entry plus the official code-server SVG favicon as the app logo.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
APP_METAentry for the new armbian/sdk images so they render under Dedicated Applications on board download pages, alongside Kali / Home Assistant / OMV / openHAB.apps/www/public/app-code-server.pngHow the data flows
application: "sdk"end-to-end:file_application: "sdk"per image (the kernel suffix6.18.26-sdkis detected by the manifest writer'slast_token.isalpha()rule).armbian-images.jsoninto the canonical index verbatim, preserving theapplicationfield.application: "sdk"againstAPP_META.sdkand renders the row with the new label + logo.No code changes outside
APP_META— same plumbing the existing four apps go through.Related
Test plan
application: "sdk"rows renders the Code server + Armbian sources entry under Dedicated Applications./app-code-server.png(no 404).