Fix plot exception: 'seaborn-whitegrid' is not a valid package style, path of style file#156
Open
csrgxtu wants to merge 2 commits intoarundo:masterfrom
Open
Fix plot exception: 'seaborn-whitegrid' is not a valid package style, path of style file#156csrgxtu wants to merge 2 commits intoarundo:masterfrom
csrgxtu wants to merge 2 commits intoarundo:masterfrom
Conversation
Merge v0.6.2 to branch develop
Author
Author
|
@tailaiw @roycoding plz help review this PR. |
|
Any chance this gets approved? |
|
Can you guys merge it please? |
earthgecko
added a commit
to earthgecko/adtk
that referenced
this pull request
Jun 12, 2025
IssueID #5631: Replace deprecated seaborn-whitegrid - Replace deprecated seaborn-whitegrid with seaborn-v0_8-whitegrid to address arundo#152 arundo#156 Modified: src/adtk/visualization/_visualization.py
earthgecko
added a commit
to earthgecko/adtk
that referenced
this pull request
Jun 12, 2025
IssueID #5631: Replace deprecated seaborn-whitegrid - Replace deprecated seaborn-whitegrid with seaborn-v0_8-whitegrid to address arundo#152 arundo#156 Modified: src/adtk/visualization/_visualization.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

when you use adtk==0.6.2 and plot the data, you will get following, that's because the
matplotlibwhich is required byadtkinstalled don't haveseaborn-whitegridin recent versions. for styles available, you can refer: https://matplotlib.org/stable/gallery/style_sheets/style_sheets_reference.htmlTo use recent
matplotlibversions, we need modify the logic in_visualization.plot, make it compatible with recent versions ofmatplotlib.