Support android 16kb pages #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am running across this - I can't release to Android Play Store with vector search using sqlite-vec |
vlasky
added a commit
to vlasky/sqlite-vec
that referenced
this pull request
Dec 29, 2025
This supports upstream PR asg017#254 which needs to pass -Wl,-z,max-page-size=16384 for Android 16KB page support. Using LDFLAGS instead of CFLAGS prevents linker flags from leaking into compile-only steps, which could cause warnings or errors with stricter toolchains. Adds EXT_LDFLAGS variable to the loadable and cli targets, enabling users to pass linker-specific flags separately from compiler flags. Co-Authored-By: Oscar Franco <[email protected]> Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
@dukedorje I've made a small tweak to your PR and incorporated it into version v0.2.3-alpha of my fork. |
Author
|
@vlasky thanks for that PR. I'm still learning the ins and outs of C compilation and makefiles and today I learned why use LDFLAGS instead of CFLAGS :) I've updated the PR accordingly mimicking your changes |
|
seems the commit is not merged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android now requires 16kb memory pages. Users cannot submit app updates until all libraries and binaries have been updated.
This in theory should enable 16kbs memory pages support but I'm not 100% familiar with the build process of sqlite-vec. It would also be important to get it out ASAP so I can update op-sqlite