Add localeId of cloned assets at the root instead of injecting it into the fileName#1
Open
Add localeId of cloned assets at the root instead of injecting it into the fileName#1
Conversation
…ssetgraph root instead of injecting it into the fileName. Closes assetgraph/assetgraph-builder#479
1 similar comment
Member
|
I really like this idea. I think we should expose
Very much agreed. It's an endless source of pain and hacks whenever we break the references (as evidenced by that ag-b PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes assetgraph/assetgraph-builder#479
With this major version bump localised assets will now be placed at
/da/index.htmlrather than/index.da.html.This has the effect that anchors pointing at index routes, like
/path/to/pageinstead ofpath/to/page.html, will keep their referential coherence after runningcloneForEachLocale.IMO keeping referential integrity in the graph is of higher importance than keeping aligned with web server plugin specific file naming conventions, which can just be reconfigured. If we lose referential integrity we block any ability for graph transformations later in a pipeline from following the relations that now have no proper
to-asset.If we can find a way to make the url rewriting configurable, so the build system outputs what a server expects, that might be better. But I didn't want to spend time on it right now.