fix: remove safe-buffer dependency, use built-in Buffer#115
Open
mahmoodhamdi wants to merge 1 commit intoauth0:masterfrom
Open
fix: remove safe-buffer dependency, use built-in Buffer#115mahmoodhamdi wants to merge 1 commit intoauth0:masterfrom
mahmoodhamdi wants to merge 1 commit intoauth0:masterfrom
Conversation
The safe-buffer package was needed for Node.js versions <6 that lacked
Buffer.from() and Buffer.alloc(). All currently supported Node.js
versions include these APIs natively, making safe-buffer unnecessary.
This also fixes ESM bundling issues where safe-buffer's internal
require("buffer") causes runtime errors.
Closes auth0#112
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safe-bufferdependency frompackage.jsonrequire('safe-buffer').Bufferwith the built-inBufferglobal inlib/data-stream.js,lib/sign-stream.js,lib/verify-stream.js, andtest/jws.test.jsBuffer.from()andBuffer.alloc()are available natively in all supported Node.js versions (>=6), makingsafe-bufferunnecessarysafe-buffer's internalrequire("buffer")causes runtime errorsAll 81 tests pass.
Closes #112