Add error message to resource importer result#451
Open
gemammercado wants to merge 5 commits intomainfrom
Open
Conversation
gemammercado
force-pushed
the
resourceImporter
branch
from
aca36ba to
08191c4
Compare
chrisqm-dev
reviewed
Feb 26, 2026
Collaborator
|
Is the goal here to allow some imports to fail + adding why the import failed? |
Contributor
Author
The goal is to add the reason why the import failed to the message the lsp returns to the client. |
satyakigh
reviewed
Mar 3, 2026
| public async getResource( | ||
| typeName: ResourceType, | ||
| identifier: ResourceId, | ||
| ): Promise<{ resource?: ResourceState; error?: string }> { |
Collaborator
There was a problem hiding this comment.
Can we just throw instead? with concrete Error types/classes instead of an error string to understand if something failed
Contributor
Author
There was a problem hiding this comment.
Yes made new revision with this change
satyakigh
previously approved these changes
Mar 30, 2026
gemammercado
force-pushed
the
resourceImporter
branch
from
deceda7 to
41d1f66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an error message to the resource importer result to provide more context about why the import failed.