fix: sliding expiration cache concurrent access exceptions #1089
+32
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sliding expiration cache is not thread safe. When manually testing with 30 threads executing a query and triggering failover with the failover_v2, the following error could be displayed:
items(),keys(), andvalues()are not thread-safe when a piece of code is iterating over them. They must first be converted to a list.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.