feat(events): add VPC Lattice request/response types#521
Closed
nmoutschen wants to merge 6 commits intoaws:mainfrom
Closed
feat(events): add VPC Lattice request/response types#521nmoutschen wants to merge 6 commits intoaws:mainfrom
nmoutschen wants to merge 6 commits intoaws:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 72.90% 72.63% -0.27%
==========================================
Files 26 26
Lines 1421 1407 -14
==========================================
- Hits 1036 1022 -14
Misses 314 314
Partials 71 71 ☔ View full report in Codecov by Sentry. |
bmoffatt
reviewed
Oct 26, 2023
bmoffatt
reviewed
Nov 30, 2023
bmoffatt
added
enhancement
type/events
bmoffatt
requested changes
Dec 2, 2023
Comment on lines
+34
to
+41
| // VpcLatticeRequestIdentity contains information about the caller | ||
| type VPCLatticeRequestIdentity struct { | ||
| SourceVPCARN string `json:"sourceVpcArn"` | ||
| Type string `json:"type"` | ||
| Principal string `json:"principal"` | ||
| SessionName string `json:"sessionName"` | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
reviewing - https://docs.aws.amazon.com/vpc-lattice/latest/ug/lambda-functions.html#receive-event-from-service
missing identity fields
principalOrgID – The ID of the organization for the authenticated principal. Present only if AWS authentication is successful.
x509IssuerOu – The issuer (OU).
x509SanDns – The subject alternative name (DNS).
x509SanNameCn – The issuer alternative name (Name/CN).
x509SanUri – The subject alternative name (URI).
x509SubjectCn – The subject name (CN).
|
Closed as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #520
Description of changes:
Add events for VPC Lattice requests and response, based on https://docs.aws.amazon.com/vpc-lattice/latest/ug/lambda-functions.html and tests against a running Lambda function.