Migration smithy initial setup#3861
Draft
sbaluja wants to merge 15 commits into
Draft
Conversation
- Fix CRITICAL bug: getShapeCppName() now properly handles empty-string resolutions from HARDCODED_COLLISION_RESOLUTIONS map - Changed null-only check to check both null and empty string: resolved != null && !resolved.isEmpty() - Empty strings indicate shapes removed from model (e.g., medialive BatchUpdateScheduleResult) - Added test coverage: getHardcodedResolution and getShapeCppName for medialive empty-string case - Added ServiceNameUtil documentation comment explaining serviceMap parameter reserved for future use - Created ServiceNameUtilTest with capitalize tests
…schema-based serde)
…ub-object generation
- Register ModelCodegenPlugin in SPI file and build.gradle.kts projections - Fix CppWriter: set 2-space indent, enable trimTrailingSpaces - Fix CppWriterDelegator: add UTF-8 BOM to match C2J output - Fix CppTypeMapper: check enum before string (EnumShape extends StringShape), add default values for enum (NOT_SET), timestamp, and blob types - Fix EnumRenderer: use wire values as C++ constants (not member names), single/multi-line format based on line length - Fix MemberRenderer: non-templated setters for primitives and enums, enum-aware Add methods for lists, doc comment format escaping - Fix ModelGenerator: proper namespace structure, indent class body, class-level doc comments, Input->Request / Output->Result naming, conditional <utility> include - Fix SerdeStub: remove hardcoded indent (handled by writer) - Update EnumRendererTest for new format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.