Respect explicit opt out for Expect: 100-continue even on cross region calls - #7204
Merged
Merged
Conversation
RanVaknin
changed the title
RanVaknin
added
the
no-api-surface-area-change
RanVaknin
marked this pull request as ready for review
July 29, 2026 20:37
Fred1155
approved these changes
Jul 29, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7081
In #7057 we forced enable the
Expect: 100-continuewhen S3 cross region calls are made (even when the setting was explicitly disabled). Without the header, the service would close the connection before the body of the request was sent, resulting in an IOException instead of the expected 3xx status code needed for the implicit redirect.This PR makes the interceptor honor an explicit
expectContinueEnabled(false)on cross region calls. The header is still included by default for cross region calls, so users who don't opt out are unaffected.Only an explicit
falsedisables it. When that happens on a cross region request, we emit a DEBUG log informing the user of this risk.