fix: break circular reference cycles from non-static closures#3282
Merged
Conversation
smilkuri
force-pushed
the
fix/memory-leak-2
branch
from
98199d8 to
884642b
Compare
stobrien89
approved these changes
May 11, 2026
Member
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
Looks good, thanks @smilkuri! I see you spotted an extra one in Middleware::mapRequest()- nice catch.
stobrien89
force-pushed
the
fix/memory-leak-2
branch
from
884642b to
7e80d7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to #1273
Description of changes:
Seven middleware closures in the implicitly capture $this because they aren't declared static, creating circular references between the client and its HandlerList. Fixed by making closures static, extracting needed values into local variables and using WeakReference for the S3MultiRegionClient. Verified all 7 fixes by running the cyclic reference test script and all of them show 0 KB leaked and no cycles detected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.