add integration test for LMI functions #3863
Open
+329
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnusunny
approved these changes
Dec 17, 2025
valerena
reviewed
Dec 17, 2025
Comment on lines
+44
to
+45
| Note: This test is skipped until 12/01/2024 because the managed policy required for | ||
| the default operator role is not available until then. |
Contributor
There was a problem hiding this comment.
Remove this note (also: 2024???)
| Statement: | ||
| - Effect: Allow | ||
| Action: | ||
| - ec2:TerminateInstances |
Contributor
There was a problem hiding this comment.
Operator role doesn't need ec2:TerminateInstances anymore, since the instances will be terminated by the service-linked role.,
Comment on lines
+40
to
+47
| - ec2:DescribeAvailabilityZones | ||
| - ec2:DescribeCapacityReservations | ||
| - ec2:DescribeInstanceTypes | ||
| - ec2:DescribeInstanceTypeOfferings | ||
| - ec2:DescribeSecurityGroups | ||
| - ec2:DescribeSubnets | ||
| - ec2:DescribeInstances | ||
| - ec2:DescribeInstanceStatus |
Contributor
There was a problem hiding this comment.
Any reason to not have these in alphabetical order? (DescribeInstances before DescribeInstanceTypes for example) (or at least to have all the DescribeInstance<Something> together).
| - !Ref SubnetId | ||
| SecurityGroupIds: | ||
| - !Ref SecurityGroup | ||
| KmsKeyArn: !Ref KMSKeyArn |
Contributor
There was a problem hiding this comment.
Should we have a Capacity provider without KmsKeyArn too, since it's not needed?
Contributor
There was a problem hiding this comment.
Also without CapacityProviderName too, considering that the only thing really required is the VpcConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Add integration test for deploying application with CapacityProvider and LMI functions
Description of changes
Add test data and test cases for successfully deployment of resources.
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.