Fix auto-arrangement boundary for skirt loops#10086
Open
ggriffiniii wants to merge 1 commit intobambulab:masterfrom
Open
Fix auto-arrangement boundary for skirt loops#10086ggriffiniii wants to merge 1 commit intobambulab:masterfrom
ggriffiniii wants to merge 1 commit intobambulab:masterfrom
Conversation
The `get_real_skirt_dist` function previously only returned the configured `skirt_distance`, ignoring the actual physical width of the skirt loops themselves. This caused the auto-arrangement algorithm to not allocate sufficient space, potentially placing skirt loops outside the buildable area. This commit updates `get_real_skirt_dist` to calculate and include the total width of the skirt loops in its returned distance. The width is derived from `initial_layer_line_width`, falling back to `line_width`, `nozzle_diameter`, or a safe default of 0.4mm. It also ensures proper loop handling when a draft shield is enabled. Additionally, unit tests have been added to verify this correct boundary calculation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_real_skirt_distfunction previously only returned the configuredskirt_distance, ignoring the actual physical width of the skirt loops themselves. This caused the auto-arrangement algorithm to not allocate sufficient space, potentially placing skirt loops outside the buildable area.This commit updates
get_real_skirt_distto calculate and include the total width of the skirt loops in its returned distance. The width is derived frominitial_layer_line_width, falling back toline_width,nozzle_diameter, or a safe default of 0.4mm. It also ensures proper loop handling when a draft shield is enabled.Additionally, unit tests have been added to verify this correct boundary calculation logic.