fix: remove non-null assertions to resolve biome lint warnings#74
Open
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Open
fix: remove non-null assertions to resolve biome lint warnings#74mehmetkr-31 wants to merge 1 commit intobase:mainfrom
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Conversation
Replace forbidden non-null assertions (!) with proper type narrowing: - base-engine.ts: remove unnecessary ! since array length is already validated to be exactly 1 - svm-to-base.ts: add explicit evmCall truthiness check to the conditional instead of using non-null assertion Fixes base#73
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!) flagged by biome'snoNonNullAssertionruleChanges
src/core/protocol/engines/base-engine.tsThe array length is already validated to be exactly 1 on line 342, so the
!onmsgInitEvents[0]is unnecessary. Removed the assertion since TypeScript can infer the value is defined after the length check.src/core/protocol/routes/svm-to-base.tsevmCallis guaranteed non-null whengetBufferableCallData()returns a non-null result (it returnsnullearly if!call). Instead of usingevmCall!, added an explicitevmCalltruthiness check to the conditional (if (bufferableData && evmCall)), which lets TypeScript narrow the type naturally.Verification
bun run check:cipasses with 0 errors and 0 warningsFixes #73