Conversation
Collaborator
✅ Heimdall Review Status
|
Resolve conflicts in DeployDevNoNitro and DeployDevWithNitro by adopting the updated TEEProverRegistry.initialize signature (address[] initialProposers) from main while keeping the Proxy deployment pattern from this branch.
leopoldjoy
reviewed
Mar 31, 2026
Contributor
There was a problem hiding this comment.
This should also have risc0VerifierRouter and risc0SetBuilderImageId.
leopoldjoy
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
DeployDevNoNitroandDeployDevWithNitromultiproof deployment scripts, and adds missing deploy config fields.Changes
Proxy pattern
TransparentUpgradeableProxywith the project's ownProxycontract (src/universal/Proxy.sol), eliminating the manualPROXY_OWNER_ADDRESSstorage slot hack (vm.store) in favor of explicitupgradeTo/upgradeToAndCall+changeAdmincalls.New deploy config fields
teeChallenger,zkRangeHash, andzkAggregationHashtoDeployConfig.s.solandsepolia.json.teeProposerandteeChallengerare now registered as initial proposers inTEEProverRegistry.initialize.AggregateVerifieris constructed with real ZK hashes from config instead of zero hashes.Hardcoded values removed
8453) withcfg.l2ChainID().Type safety
mockAnchorRegistryfromaddresstoIAnchorStateRegistry, removing redundant casts throughout both scripts.JSON output
vm.serializeAddress/vm.writeJsonfor cleaner, less error-prone output.Cleanup
console.logcalls (summary is still printed at the end).