Skip to content

fix: change storage to memory in Drippie.executable() view function#239

Open
ygd58 wants to merge 1 commit intobase:mainfrom
ygd58:fix/drippie-executable-memory
Open

fix: change storage to memory in Drippie.executable() view function#239
ygd58 wants to merge 1 commit intobase:mainfrom
ygd58:fix/drippie-executable-memory

Conversation

@ygd58
Copy link
Copy Markdown

@ygd58 ygd58 commented Apr 3, 2026

Problem

The executable() function in Drippie.sol was using DripState storage state despite being a view function. This violates the view function contract and is semantically incorrect — a view function should not reference storage unnecessarily.

Fix

Changed DripState storage state to DripState memory state on line 174 in the executable() function.

Testing

forge build src/periphery/drippie/Drippie.sol

Compiler run successful.

Closes #224

@cb-heimdall
Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants