Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs fixed across SmartEscrow and Recovery contracts.
Bug 1 – SmartEscrow: incorrect total vested amount after
endThe
_vestingSchedulefunction usedOP_TOKEN.balanceOf(address(this)) + releasedwhen
timestamp > end. Because the token balance decreases as tokens are released,this makes
releasable()return a progressively lower (and eventually underflowing)amount, potentially stranding tokens in the contract permanently.
Fixed by computing total vested tokens from immutable schedule parameters only.
Also corrected
>to>=to include the exact end timestamp.Bug 2 – Recovery: silent ETH transfer failure
withdrawETHusedif (!success) continuewhich silently skips failed transfers,permanently losing ETH with no revert or event emitted.
Fixed by replacing with
require(success, ...)to revert the entire batch on failure.