Skip to content

fix(SuperchainConfig): extend() must check paused() to prevent re-activating expired pauses #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sertug17 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(SuperchainConfig): extend() must check paused() to prevent re-activating expired pauses #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1c344d
fix(SuperchainConfig): extend() should check paused() to prevent re-a…
Sertug17 Aug 1, 2026
0b2bcdd
test(SuperchainConfig): add testFuzz_extend_expiredPause_reverts
Sertug17 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/L1/SuperchainConfig.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ contract SuperchainConfig is ProxyAdminOwnedBase, ISemver {
_assertOnlyGuardian();

// Cannot extend the pause if not already paused.
if (pauseTimestamps[_identifier] == 0) {
if (!paused(_identifier)) {
revert SuperchainConfig_NotAlreadyPaused(_identifier);
}

Expand Down
13 changes: 13 additions & 0 deletions test/L1/SuperchainConfig.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,19 @@ contract SuperchainConfig_Extend_Test is SuperchainConfig_TestInit {
);
superchainConfig.extend(_identifier);
}

/// @notice Tests that `extend` reverts when the pause has already expired.
/// @param _identifier The identifier to test.
function testFuzz_extend_expiredPause_reverts(address _identifier) external {
_pauseAsGuardian(_identifier);
vm.warp(block.timestamp + PAUSE_EXPIRY + 1);
assertFalse(superchainConfig.paused(_identifier));
vm.prank(superchainConfig.guardian());
vm.expectRevert(
abi.encodeWithSelector(ISuperchainConfig.SuperchainConfig_NotAlreadyPaused.selector, _identifier)
);
superchainConfig.extend(_identifier);
}
}

/// @title SuperchainConfig_Pausable_Test
Expand Down