Add draft pagination and draft workflow commands via web forms#118
Open
mikegyi wants to merge 17 commits into
Open
Add draft pagination and draft workflow commands via web forms#118mikegyi wants to merge 17 commits into
mikegyi wants to merge 17 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds first-class draft workflows to the HEY CLI, enabling users (and agents/scripts) to create/update/delete drafts and to save drafts from existing compose/reply flows without sending.
Changes:
- Introduces
hey draft {create,update,delete}and adds--draftsupport tohey composeandhey reply. - Improves
hey draftsto paginate through results and provide more accurate truncation messaging. - Updates command help surfacing and documentation (README, SKILL doc, surface file) to reflect the new draft capabilities.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/hey/SKILL.md | Documents new draft commands and --draft usage for compose/reply. |
| internal/cmd/root.go | Exposes an HTTP client for draft web-form submission and registers the new draft command. |
| internal/cmd/reply.go | Adds --draft to save reply drafts instead of sending immediately. |
| internal/cmd/compose.go | Adds --draft to save drafts for new messages or thread posts. |
| internal/cmd/help.go | Includes draft in curated help categories. |
| internal/cmd/drafts.go | Reworks drafts listing to paginate and parse Link headers safely. |
| internal/cmd/drafts_test.go | Adds unit tests for pagination, link parsing, origin checks, and truncation notices. |
| internal/cmd/draft.go | Implements draft create/update/delete via authenticated web form flows (CSRF parsing, submission). |
| internal/cmd/draft_test.go | Adds unit tests for form value generation, parsing, and update validation behavior. |
| README.md | Adds examples for --draft and hey draft ... usage. |
| DRAFT_SUPPORT_NOTE.md | Adds implementation rationale and constraints for draft support. |
| .surface | Updates surfaced CLI command/flag inventory for draft-related commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+90
| func fetchDraftsPage(ctx context.Context, pageURL string) ([]generated.DraftMessage, string, int, error) { | ||
| if strings.HasPrefix(pageURL, "http://") || strings.HasPrefix(pageURL, "https://") { | ||
| if err := validateSameOrigin(sdk.Config().BaseURL, pageURL); err != nil { | ||
| return nil, "", 0, err | ||
| } | ||
| } | ||
|
|
||
| resp, err := sdk.Get(ctx, pageURL) | ||
| if err != nil { | ||
| return nil, "", 0, convertSDKError(err) | ||
| } |
Comment on lines
+87
to
+95
| resp, err := sdk.Get(ctx, pageURL) | ||
| if err != nil { | ||
| return nil, "", 0, convertSDKError(err) | ||
| } | ||
|
|
||
| var drafts []generated.DraftMessage | ||
| if err := resp.UnmarshalData(&drafts); err != nil { | ||
| return nil, "", 0, fmt.Errorf("failed to parse drafts response: %w", err) | ||
| } |
Comment on lines
+462
to
+471
| defer func() { _ = resp.Body.Close() }() | ||
| body, _ := io.ReadAll(resp.Body) | ||
|
|
||
| if resp.StatusCode < 200 || resp.StatusCode >= 400 { | ||
| msg := strings.TrimSpace(string(body)) | ||
| if msg == "" { | ||
| msg = resp.Status | ||
| } | ||
| return draftResponse{}, output.ErrAPI(resp.StatusCode, msg) | ||
| } |
Comment on lines
+485
to
+496
| func draftResponseFromLocation(location string) draftResponse { | ||
| if location == "" { | ||
| return draftResponse{} | ||
| } | ||
| location = strings.TrimRight(location, "/") | ||
| id, _ := strconv.ParseInt(location[strings.LastIndex(location, "/")+1:], 10, 64) | ||
| return draftResponse{ | ||
| ID: id, | ||
| URL: location, | ||
| EditURL: location + "/edit", | ||
| } | ||
| } |
| composeCommand.cmd.Flags().StringVar(&composeCommand.subject, "subject", "", "Message subject (required)") | ||
| composeCommand.cmd.Flags().StringVarP(&composeCommand.message, "message", "m", "", "Message body (or opens $EDITOR)") | ||
| composeCommand.cmd.Flags().StringVar(&composeCommand.threadID, "thread-id", "", "Thread ID to post message to") | ||
| composeCommand.cmd.Flags().BoolVar(&composeCommand.draft, "draft", false, "Save as draft instead of sending") |
Comment on lines
+91
to
+96
| if c.draft { | ||
| return createReplyDraft(ctx, cmd.OutOrStdout(), topicID, draftFormRequest{ | ||
| Subject: c.subject, | ||
| Content: message, | ||
| }) | ||
| } |
Comment on lines
+104
to
+112
| if c.draft { | ||
| return createMessageDraft(ctx, cmd.OutOrStdout(), draftFormRequest{ | ||
| Subject: c.subject, | ||
| Content: message, | ||
| To: to, | ||
| CC: cc, | ||
| BCC: bcc, | ||
| }) | ||
| } |
| } | ||
|
|
||
| replyCommand.cmd.Flags().StringVarP(&replyCommand.message, "message", "m", "", "Reply message (or opens $EDITOR)") | ||
| replyCommand.cmd.Flags().BoolVar(&replyCommand.draft, "draft", false, "Save as draft instead of sending") |
Comment on lines
+86
to
+90
| if c.draft { | ||
| return createReplyDraftForEntry(ctx, cmd.OutOrStdout(), latestEntryID, draftFormRequest{ | ||
| Content: message, | ||
| }) | ||
| } |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 12 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Comment on lines
+81
to
+89
| func (c *draftCreateCommand) run(cmd *cobra.Command, args []string) error { | ||
| if err := requireAuth(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| message, err := draftMessage(c.message) | ||
| if err != nil { | ||
| return err | ||
| } |
Comment on lines
+107
to
+114
| func normalizeDraftsPageURL(baseURL, pageURL string) (string, error) { | ||
| parsed, err := url.Parse(pageURL) | ||
| if err != nil { | ||
| return "", fmt.Errorf("invalid pagination URL: %w", err) | ||
| } | ||
| if parsed.Host == "" { | ||
| return pageURL, nil | ||
| } |
Comment on lines
+469
to
+477
| if resp.StatusCode < 200 || resp.StatusCode >= 400 { | ||
| msg := resp.Status | ||
| if readErr == nil { | ||
| if bodyText := strings.TrimSpace(string(body)); bodyText != "" { | ||
| msg = bodyText | ||
| } | ||
| } | ||
| return draftResponse{}, output.ErrAPI(resp.StatusCode, msg) | ||
| } |
Comment on lines
+227
to
233
| if target.Scheme == "" && target.Host != "" { | ||
| target.Scheme = base.Scheme | ||
| } | ||
| if !strings.EqualFold(base.Scheme, target.Scheme) || base.Host != target.Host { | ||
| return fmt.Errorf("pagination URL origin %s://%s does not match base %s://%s", | ||
| target.Scheme, target.Host, base.Scheme, base.Host) | ||
| } |
Review carefully before merging. Consider a major version bump. |
jmcascalheira
pushed a commit
to jmcascalheira/hey-cli
that referenced
this pull request
Jun 18, 2026
…) — revert when merged upstream Squash of mikegyi:mike/draft-workflows as of commit d222206 (the state at backport time). Adds: hey draft create [--to/--cc/--bcc <addrs>] [--subject S] [-m BODY] [--thread-id <topic-id>] [--all] hey draft update <id> [--to/--cc/--bcc] [--subject] [-m BODY] hey draft delete <id> hey drafts --all / --limit N (paginated listing) Backed by HEY's authenticated web-form endpoints (Turbo-style), same pattern the calendar-events backport uses. Marked experimental upstream — author has manually tested two reply drafts; broader real-world testing is ongoing. Local adjustments on top of the squashed PR: - Did NOT take internal/cmd/compose.go or internal/cmd/reply.go modifications (those files remain deleted per the no-send fork policy). The PR's '--draft' flag additions to compose/reply are therefore not applicable. - Created internal/cmd/addresses.go containing parseAddresses() — extracted from the deleted compose.go because draft.go needs the helper. - Deleted internal/cmd/draft_command_test.go: it tested the --draft flag on compose/reply, which we don't ship. - Kept all other new test files (draft_test.go, drafts_test.go). - Edited skills/hey/SKILL.md: replaced the 'Sending Email — Not supported' paragraph with a 'Sending Email — pre-write as drafts' workflow now that drafts work; preserved the no-send disclaimer. - internal/cmd/help.go: added 'draft' to the curated EMAIL list. Live-tested end-to-end against my own HEY account: created a draft, confirmed it appeared in 'hey drafts' listing, deleted it. No send occurred at any step. WHEN basecamp#118 MERGES UPSTREAM: 1. git log --oneline | grep TEMPORARY # find this commit's SHA 2. git revert <sha> # also reverts the PR basecamp#79 backport # if not already reverted — keep # both reverts in sequence 3. git checkout main && git fetch upstream && git merge --ff-only upstream/main 4. git push origin main 5. git checkout nosend && git merge main # During this merge, re-resolve compose.go / reply.go as deleted # (upstream's compose.go modifications, including the --draft flag, # are not wanted by the no-send fork). 6. make build && make test 7. git push origin nosend The official version may include review-feedback tweaks not present here. Reverting this commit first ensures a clean swap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds fuller draft support to
hey-cli.The API-safe part is draft listing pagination:
hey drafts --allhey drafts --limit NLinkheaderIt also adds an experimental draft workflow:
hey draft createhey draft updatehey draft deletehey compose --drafthey reply --draftAPI surface note
Draft listing uses HEY’s JSON endpoint.
Draft create/update/delete currently use HEY’s authenticated web form flow because the SDK does not expose first-class draft mutation methods yet. I kept that code isolated so it can be replaced with SDK/API calls if those endpoints become available.
This means the mutation commands are useful as a working implementation and command-shape proposal, but they are less stable than the listing/pagination work.
Safety notes
<br>line breaks so HEY preserves spacing.Authoring note
This was authored by Mike Gyi with Codex 5.5.
The intent was to explore a practical draft workflow for
hey-cli, using Basecamp’s own CLI taste as the reference point: small commands, direct behavior, clear failure modes, and no hidden send action.Testing
go test ./internal/cmd -run 'TestDraftValues|TestWithReplyFormRecipients|TestParseDraftForm|TestReply|TestCreateReplyDraft'make build && make testSummary by cubic
Adds full draft support to
hey-cli: paginated drafts,hey draftcommands, and--draftoncompose/reply, with unified message input, safer pagination/recipients, and clearer draft error messages.This lets you save, update, and delete drafts from the CLI without sending.
New Features
hey draftswith--alland--limit; followsLinkrel=next (absolute or scheme-relative), readsX-Total-Count, and caps traversal with a clear limit notice.hey draft create|update|delete,hey draft create --thread-idfor reply drafts, plushey compose --draftandhey reply --draft.Bug Fixes
Written for commit d222206. Summary will update on new commits.
Manual testing scope
I have started using the draft workflow against my own HEY account, but it has not had broad real-world testing yet.
So far the live testing covered two reply drafts. That surfaced two important bugs: reply drafts could inherit unsafe recipient state from a broader thread, and plain-text line breaks collapsed in HEY. Both are fixed in this PR.
I plan to keep using this workflow myself and will keep fixing issues as they come up.