-
-
Notifications
You must be signed in to change notification settings - Fork 654
chore: make builtin build_python_zip flag optional for tests (bazel 10 compatibility) #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make builtin build_python_zip flag optional for tests (bazel 10 compatibility) #3507
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project to maintain compatibility with Bazel 10 by making the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the build configuration and tests to be compatible with Bazel 10, where the build_python_zip flag is removed. The changes correctly introduce a bazel_10_or_later configuration flag and use it to conditionally apply the build_python_zip flag in tests and transitions. My review includes a couple of suggestions to improve code consistency and clarity for better long-term maintainability.
|
Great! Thanks, @rickeylev! |
Starting in bazel 10, the build_python_zip flag is removed. This means using
the flag in e.g. transitions no longer works, which breaks some of the tests
that set the flag for testing.
To fix, don't set the flags or add them to transitions when running under
bazel 10.
Fixes #3496