chore: cherry-picks for 2.3.2 - #4089
Merged
Merged
Conversation
Source-less wheels with dependency metadata fail analysis because the generated wrapper `py_library` puts an empty `:srcs` target in its `srcs` attribute. This forwards `:srcs` through the wrapper only when it produces Python sources, while retaining it in `deps` for `PyInfo` propagation. Before this change, [`py-spy==0.4.1`](https://pypi.org/project/py-spy/0.4.1/) dependency fails during analysis. Afterward, it can be used as a dependency. Adds regression coverage for source-less, sourceful, and generated namespace-package source targets, along with a news entry. Largely implemented with Opus. Fixes #4053. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> (cherry picked from commit 4f4eafd)
Git sources in `uv.lock` can include a revision in the URL query and fragment. `pip.parse` currently includes those components in the derived filename, which can produce an invalid Bazel repository name. Derive the filename from only the URL path while preserving the complete revision-bearing Git URL. Regression coverage verifies the filename is clean and the fetch URL remains unchanged. Fixes #4084 (cherry picked from commit 984d485)
Collaborator
Author
|
FYI, we don't have a flow for this, but this is not too difficult to potentially automate. The rough list of commands: git checkout main
git pull
git checkout release/2.3
git pull
for pr in 4044 4045; do
git cherry-pick -x "$(git log --oneline main | grep "$pr" | awk '{print $1}')"
done
# create a changelog entry - I think we have a script for that, but I did it manually
# ensure the VERSION_NEXT_FEATURE and similar are correctly accounted for.We probably are not doing enough bugfixes to warrant automation though. |
Collaborator
|
I created a workflow for this |
rickeylev
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks:
Extra fixes (PR to main in #4090):
Work towards #4088