Support --incompatible_exclude_starlark_flags_from_exec_config.#4056
Open
slackito wants to merge 1 commit into
Open
Support --incompatible_exclude_starlark_flags_from_exec_config.#4056slackito wants to merge 1 commit into
--incompatible_exclude_starlark_flags_from_exec_config.#4056slackito wants to merge 1 commit into
Conversation
slackito
force-pushed
the
exclude_starlark_flags_from_exec_config
branch
from
1356f36 to
c694d74
Compare
krasimirgg
reviewed
May 28, 2026
| rust_toolchain_channel_flag = rule( | ||
| doc = "A build setting which represents the Rust toolchain channel. The allowed values are {}".format(_CHANNELS), | ||
| implementation = _rust_toolchain_channel_flag_impl, | ||
| attrs = {"scope": attr.string(default = "universal")}, |
Collaborator
There was a problem hiding this comment.
not super familiar with this flag, this sounds OK but just tagging -- @UebelAndre to double-check -- idea is that if we're using say nightly for the target platform, we should be also using nightly for the exec one at least for consistently with proc-macros I think?
Collaborator
There was a problem hiding this comment.
I think this makes sense. We really want the same toolchain to be used when switching between rlib and proc macro outputs (obviously transitioning the target platform) so for now this makes the most sense to me :)
This change adds `scope = "universal"` to some settings that need to be preserved in exec config.
slackito
force-pushed
the
exclude_starlark_flags_from_exec_config
branch
from
c694d74 to
ef97435
Compare
UebelAndre
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
scope = "universal"to some settings that need to be preserved in exec config.