Skip to content

remove default urls and rid#89

Merged
elewis2 merged 15 commits intodevelopfrom
feat/DEVSU-2797-remove-gsc-defaults
Jan 7, 2026
Merged

remove default urls and rid#89
elewis2 merged 15 commits intodevelopfrom
feat/DEVSU-2797-remove-gsc-defaults

Conversation

@elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Dec 9, 2025

Removes default GSC urls and preferred_source_gene rid. Build/deploy plans will likely need updating.

@elewis2 elewis2 marked this pull request as draft December 9, 2025 22:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.10%. Comparing base (ddb48c4) to head (e290da6).

Files with missing lines Patch % Lines
pori_python/ipr/main.py 52.94% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (57.89%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
- Coverage    83.31%   83.10%   -0.22%     
===========================================
  Files           18       18              
  Lines         2458     2462       +4     
===========================================
- Hits          2048     2046       -2     
- Misses         410      416       +6     
Flag Coverage Δ
unittests 83.10% <57.89%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elewis2 elewis2 marked this pull request as ready for review December 10, 2025 19:08
@elewis2 elewis2 requested review from Copilot, dustinbleile and mathieulemieux and removed request for Copilot December 10, 2025 19:08
@elewis2 elewis2 requested a review from dustinbleile December 11, 2025 17:26
mathieulemieux
mathieulemieux previously approved these changes Dec 11, 2025
Copy link
Member

@mathieulemieux mathieulemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upload tests are passing

@elewis2 elewis2 merged commit 1219643 into develop Jan 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants